| Year | Film | Role | Notes |
|---|---|---|---|
| 1930 | Sinners' Holiday | Harry Delano | aka Women In Love |
| 1930 | The Doorway To Hell | Steve Mileaway | aka A Handful Of Clouds |
| 1931 | Other Men's Women | Ed 'Eddie' Bailey | aka The Steel Highway |
| 1931 | The Public Enemy | Tom Powers | His breakthrough role |
| 1931 | The Millionaire | Schofield | |
| 1931 | Smart Money | Jack | With Edward G. Robinson |
| 1931 | Blonde Crazy | Bert Harris | aka Larceny Lane |
| 1932 | Taxi! | Matt Nolan | |
| 1932 | The Crowd Roars | Joe Greer | |
| 1932 | Winner Takes All | Jim 'Jimmy' Kane | |
| 1933 | Hard To Handle | Myron C. 'Lefty' Merrill | |
| 1933 | Picture Snatcher | Danny Keane | |
| 1933 | The Mayor Of Hell | Richard 'Patsy' Gargan | |
| 1933 | Footlight Parade | Chester Kent | |
| 1933 | Lady Killer | Dan Quigley | |
| 1934 | Jimmy The Gent | 'Jimmy' Corrigan | |
| 1934 | He Was Her Man | Flicker Hayes | |
| 1934 | Here Comes The Navy | Chesty O'Conner | Ist with Pat O'Brien |
| 1934 | The St. Louis Kid | Eddie Kennedy | aka A Perfect Week-End |
| 1935 | Devil Dogs Of The Air | 'Tommy' O'Toole | |
| 1935 | G Men | 'Brick' Davis | |
| 1935 | The Irish In Us | Danny O'Hara | |
| 1935 | A Midsummer Night's Dream | Bottom | Shakespeare role |
| 1935 | Mutiny On The Bounty | Extra | No screen credit |
| 1935 | Frisco Kid | Bat Morgan | |
| 1936 | Ceiling Zero | Dizzy Davis | |
| 1936 | Great Guy | Johnny 'Red' Cave | aka Pluck Of The Irish |
| 1937 | Something To Sing About | Terrence 'Terry' Rooney | |
| 1938 | Boy Meets Girl | Robert Law | |
| 1938 | Angels With Dirty Faces | Rocky Sullivan | Oscar nomination/actor |
| 1939 | The Oklahoma Kid | Jim Kincaid | With Humphrey Bogart |
| 1939 | Each Dawn I Die | Frank Ross | |
| 1939 | The Roaring Twenties | Eddie Bartlett | With Humphrey Bogart |
| 1940 | The Fighting 69th | Private Jerry Plunkett | |
| 1940 | Torrid Zone | Nick 'Nicky' Butler | |
| 1940 | City For Conquest | Danny Kenny | |
| 1941 | The Strawberry Blonde | T. L. 'Biff' Grimes | With Rita Hayworth |
| 1941 | The Bride Came C.O.D. | Steve Collins | With Bette Davis |
| 1942 | Captains Of The Clouds | Brian MacLean | |
| 1942 | Yankee Doodle Dandy | George M. Cohan | Oscar winner/actor |
| 1943 | You, John Jones! | John Jones | |
| 1943 | Johnny Come Lately | Tom Richards | aka Johnny Vagabond |
| 1945 | Blood On The Sun | Nick Condon | |
| 1947 | 13 Rue Madeleine | Robert Emmett | |
| 1948 | The Time Of Your Life | Joseph T | |
| 1949 | White Heat | Cody Jarrett | With Virginia Mayo |
| 1950 | Kisss Tomorrow Goodbye | Ralph Cotter | |
| 1950 | The West Point Story | Elwin 'Bix' Bixby | With Doris Day |
| 1951 | Come Fill The Cup | Lew Marsh | |
| 1952 | What Price Glory | Capt. Flagg | |
| 1953 | A Lion In The Streets | Hank Martin | |
| 1955 | Run For Cover | Matt Dow | |
| 1955 | Love Me Or Leave Me | Martin Snyder | Oscar nomination/actor |
| 1955 | The Seven Little Foys | George M. Cohan | With Bob Hope |
| 1955 | Mister Roberts | Capt. Morton | Henry Fonda in title role |
| 1956 | Tribute To A Bad Man | Jeremy Rodock | |
| 1956 | These Wilder Years | Steve Bradford | |
| 1957 | Man Of A Thousand Faces | Lon Chaney | |
| 1959 | Never Steal Anything Small | Jake MacIllaney | |
| 1959 | Shake Hands With The Devil | Sean Lenihan | |
| 1960 | The Gallant Hours | Admiral Halsey Jr | Also producer |
| 1961 | One, Two, Three | C.R. MacNamara | |
| 1966 | Ballad Of Smokey The Bear | Narrator | TV movie |
| 1968 | Arizona Bushwhackers | Narrator | |
| 1981 | Ragtime | Rhinelander Waldo | |
| 1984 | Terrible Joe Moran | Joe Moran | TV movie |